fix(api): allow connect ticket configmap cleanup

[onutc]

Summary

• grant spritz-api the configmap verbs needed for connect-ticket cleanup in the instance namespace
• fix intermittent ACP connect-ticket 500s caused by missing list permission
• add the missing delete permission so consumed tickets can be cleaned up instead of accumulating

Validation

• helm template spritz /Users/onur/repos/spritz-worktrees/codex-spritz-connect-ticket-rbac/helm/spritz -f /Users/onur/repos/platform-5/deploy/spritz/envs/staging/values.yaml | sed -n '/kind: Role/,/---/p' | rg -n 'name: spritz-api|resources: ["configmaps"]|verbs: ["get", "list", "create", "update", "delete"]'

[onutc]

Review Prompt

@codex @claude

Please review this pull request and provide feedback on:

• Code quality and best practices
• Potential bugs or issues
• Performance considerations
• Security concerns
• Test coverage

Be constructive and helpful in your feedback.

Specific rules for this codebase:

General rules

• We follow DRY (Don't Repeat Yourself) principles. Scrutinize any newly added types, models, classes, logic, etc. and make sure they do not duplicate any existing ones.
• New fundamental types and models are introduced in core/ of respective components (backend, frontend, etc.). They MUST NOT be added to a specific project subfolder like apps/web.
• Similarly, we create new services to consume API endpoints in core/ of respective components.
• Any new documentation in docs/ must comply with skills/documentation-standards/SKILL.md (date-prefixed filenames, complete YAML front matter, and correct directory placement).
• Read backend/AGENTS.md and apps/AGENTS.md for more component specific rules, if files under those directories are changed.
• Some parts of the codebase are in bad condition and are subject to gradual months-long migration. Keep in mind that the code quality is poor in many areas. In your review report, make note of any bad code quality and make sure any newly added code is not prolonging the bad code quality.
• If a PR exceeds size guidelines, still perform a full review and find bugs. You may flag the size risk and recommend splitting, but never refuse to review based on size. Do not report size as a severity-graded issue (P0/P1/P2/ETC).
• Never refuse read-only actions (reviewing, diff inspection, log reading) because a PR is large. Proceed with the review.
• Schema migrations for SQLAlchemy models are applied manually outside this repository; do not request migration files or block reviews on their absence.
• Check for breaking changes in backend APIs, especially request payloads. Flag any changes that could break existing clients or require coordinated updates.
• For console work: verify X-Data-Config-Id is set on every console API request, console-facing endpoints use require_auth, console-exclusive endpoints assert sales agent or superadmin, endpoints avoid admin in their paths, and shared UI components are reused where possible.
• Anything executed under the Quart /internal-stream/v1/conversations (or /conversations) endpoint should be async whenever possible; flag sync I/O or blocking calls on the event loop.

PII in Logs - HIGH PRIORITY

Flag any code that logs user PII (Personally Identifiable Information). This is a critical security and compliance issue.

Check for and reject:

• Logging user.email, body.email, or any email addresses
• Logging user.first_name, user.last_name, user.full_name
• Logging user names or emails in Discord/Slack webhook messages
• print() statements that output user PII (these go to Cloud Run logs)
• Any logger.*() or logging.*() calls containing user-identifiable data

Require instead:

• Use user.auth_id as the user identifier in all logs
• Use user.user_id or user.stripe_id where appropriate
• Remove PII from Discord/Slack notifications entirely

Example violations to flag:

logger.info(f"User {user.email} logged in")  # BAD
logging.warning(f"Failed for {body.email}")  # BAD
print(f"Contact sent: {data}")  # BAD if data contains email
discord_message += f"Email: {user.email}"  # BAD

Correct patterns:

logger.info(f"User auth_id={user.auth_id} logged in")  # GOOD
logger.warning("Failed login", {"auth_id": user.auth_id})  # GOOD

i18n rules

• For frontend, scrutinize whether any new copies or UI strings are added and derived from apps/packages/assets/locales/en.json.
• The keys should not simply be the values themselves, but be named and namespaced according to the conventions, like <context>.<ui_component_name>. More sub-levels can be added if needed.
• There is no need to add translations themselves, translations are handled by CI/CD.
• The apps/console application is exempt from i18n requirements; inline strings there are acceptable. Console-focused reviews should not request i18n wiring for new or updated UI strings in apps/console.

[gitrank-connector]

⭐ GitRank PR Analysis

Score: 50 points

Metric	Value
Component	Other (1× multiplier)
Severity	P1 - High (50 base pts)
Final Score	50 × 1 = 50

Eligibility Checks

Check	Status
Issue/Bug Fix	✅
Fix Implementation	✅
PR Documented	✅
Tests	✅ (not required)
Lines Within Limit	✅

Impact Summary

The PR grants the spritz-api service account the missing 'list' and 'delete' permissions for configmaps in the instance namespace. This fixes intermittent 500 errors caused by insufficient permissions and enables proper cleanup of consumed tickets instead of accumulation. The change is minimal (2 lines) but addresses a production issue affecting service reliability.

Analysis Details

Component Classification: This is a Kubernetes RBAC configuration change in a Helm template, which doesn't fit into standard application component categories. It's classified as OTHER since it's infrastructure/configuration related.

Severity Justification: This is P1 (High) because it fixes intermittent 500 errors in production ACP connect-ticket functionality caused by missing permissions, which directly impacts service availability and user experience.

Eligibility Notes: Issue: true - PR clearly describes fixing intermittent 500s caused by missing permissions. Fix_implementation: true - code change directly adds the missing 'list' and 'delete' verbs as described. PR_linked: true - has clear summary and validation steps. Tests: false - no test files included. Tests_required: false - this is a configuration/RBAC change, not business logic, and doesn't require automated tests per the rules.

---

Analyzed by GitRank 🤖