fix: expose rendered binding template internally#232
Conversation
👍 GitRank PR AnalysisScore: 20 points
Eligibility Checks
Impact SummaryThis PR exposes rendered binding template details in the internal binding API response, enabling deployments to detect and repair target mismatches between saved desired state and live SpritzBinding state. It includes comprehensive documentation of the binding target reconciliation contract and adds regression tests verifying that resolved service account and agent references are visible in the internal binding read response. The change prevents a correctness bug where Spritz could route traffic to the wrong runtime after a target change. Analysis DetailsComponent Classification: This PR affects internal API response structures and binding reconciliation logic, which doesn't fit cleanly into a specific domain component. It's classified as OTHER since it's a cross-cutting internal API enhancement. Severity Justification: This is a P2 (Medium) severity fix. It addresses a correctness bug where stale runtime state could silently serve traffic after target changes, but includes a workaround (manual repair) and doesn't cause immediate service outage. The fix is preventative and enables proper state reconciliation. Eligibility Notes: Issue: True - PR explicitly fixes a correctness bug (stale runtime state serving traffic). Fix Implementation: True - code changes expose template details and add test coverage as described. PR Linked: True - comprehensive description with summary, tests, and staging notes. Tests: True - includes regression test in internal_bindings_test.go with new helper function. Tests Required: True - this is a bug fix in business logic (binding reconciliation) and API contract change, both requiring test coverage to prevent regression. Analyzed by GitRank 🤖 |
Summary
Tests
Staging
Pending merge and staging deployment verification.