Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for math equation markup in Typst documents by converting Marked::Equation nodes to Code or CodeBlock AST nodes.
- Converts inline math expressions (single-line) to
Codenodes - Converts block math expressions (standalone lines or multi-line) to
CodeBlocknodes - Updates the README to reflect that math markup is now supported
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/typstToTextlintAst.ts | Adds conversion logic for Marked::Equation nodes to determine Code vs CodeBlock type |
| test/unit/textlintAstObject.json | Updates test data to show equation nodes converted to Code/CodeBlock types |
| test/unit/paragraphizedTextlintAstObject.json | Updates paragraphized test data with converted equation nodes |
| test/unit/fixtures/Equation/output.json | Adds expected output for equation parsing test |
| test/unit/fixtures/Equation/input.typ | Adds test input file with math equations |
| README.md | Updates documentation to show math markup is supported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.