Skip to content

Adding missing default constructors #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThibaultDECO wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding missing default constructors #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea1cd6
Adding missing default constructors (#5)
ThibaultDECO Sep 10, 2022
b52af8e
Merge branch 'master' into Master5
ThibaultDECO Oct 9, 2022
9b0f5a7
Merge branch 'master' into Master5
ThibaultDECO Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/xlnt/drawing/spreadsheet_drawing.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ namespace drawing {
class XLNT_API spreadsheet_drawing
{
public:
spreadsheet_drawing();
spreadsheet_drawing(xml::parser &parser);
void serialize(xml::serializer &serializer);

Expand Down
8 changes: 8 additions & 0 deletions include/xlnt/styles/format.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ class xlsx_consumer;
class XLNT_API format
{
public:
/// <summary>
/// Default contructor.
/// </summary>
format()
: d_(nullptr)
{
};

/// <summary>
/// Returns the alignment of this format.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions source/drawing/spreadsheet_drawing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ std::vector<std::string> copy_and_extract(xml::parser &p, xml::serializer &s)
namespace xlnt {
namespace drawing {

spreadsheet_drawing::spreadsheet_drawing()
{
embed_ids_ = std::vector<std::string>();
serialized_value_ = std::string();
}

spreadsheet_drawing::spreadsheet_drawing(xml::parser &parser)
{
std::ostringstream serialization_stream;
Expand Down