Fixed compilation failure on gcc 13, added includes, tests fine#710
Open
commel wants to merge 1 commit intotfussell:masterfrom
Open
Fixed compilation failure on gcc 13, added includes, tests fine#710commel wants to merge 1 commit intotfussell:masterfrom
commel wants to merge 1 commit intotfussell:masterfrom
Conversation
…ed and include was missing. All tests run file
Author
|
Hi @tfussell could you merge this, so I can return using the repo instead of a patched version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Requests fixes the compilation failures on gcc 13 (g++) on Linux. I've added the includes where the numerics where used. The tests built fine and executed without errors:
Superseeds #708 and #704 because I've looked at all the files and executed the test suite and PR authors don't respond.