Skip to content

create or copy sheet error #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mensong wants to merge 2 commits into
base: master
Choose a base branch
from
Open

create or copy sheet error #719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508c9c4
fix:create_sheet(index) index>sheetcount error
mensong Nov 3, 2023
22e1868
fix:copy_sheet index>sheetcount error
mensong Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/workbook/workbook.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,9 @@ worksheet workbook::copy_sheet(worksheet to_copy)

worksheet workbook::copy_sheet(worksheet to_copy, std::size_t index)
{
if (index > d_->worksheets_.size())
throw invalid_parameter();

copy_sheet(to_copy);

if (index != d_->worksheets_.size() - 1)
Expand Down Expand Up @@ -1091,6 +1094,11 @@ void workbook::remove_sheet(worksheet ws)

worksheet workbook::create_sheet(std::size_t index)
{
if (index > d_->worksheets_.size())
{
throw invalid_parameter();
}

create_sheet();

if (index != d_->worksheets_.size() - 1)
Expand Down