Dynamic Node Labels - #386
Merged
Merged
Conversation
Jacob-Chmura
marked this pull request as ready for review
January 16, 2026 20:19
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ntgbaoo
previously requested changes
Jan 17, 2026
| node_x_mask (Tensor | None): Indices of node events within `time`. | ||
| node_x_nids (Tensor | None): Node IDs corresponding to node events [num_node_events]. | ||
| node_x (Tensor | None): Node features over time [num_node_events, D_node_dynamic]. | ||
| node_y_mask (Tensor | None): Indices of node labels within `time`. |
Member
There was a problem hiding this comment.
Suggested change
| node_y_mask (Tensor | None): Indices of node labels within `time`. | |
| node_y_mask (Tensor | None): Mask of node events within `time`. |
Member
There was a problem hiding this comment.
This is called Dynamic node features for nodes in DGBatch.
ntgbaoo
approved these changes
Jan 17, 2026
ntgbaoo
left a comment
ntgbaoo
left a comment
Member
There was a problem hiding this comment.
The APIs now look very nice and clear to me. Thanks @Jacob-Chmura for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #352