Make hooks seedable and added instance-level properties - #396
Merged
Conversation
ntgbaoo
marked this pull request as draft
February 16, 2026 04:40
ntgbaoo
marked this pull request as ready for review
February 16, 2026 04:40
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Jacob-Chmura
left a comment
Member
There was a problem hiding this comment.
I've done a pass and left some thoughts on the design. The directions looks good but there are some details to iron out.
shenyangHuang
requested changes
Mar 25, 2026
shenyangHuang
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good, some comments to address
shenyangHuang
approved these changes
Apr 13, 2026
shenyangHuang
left a comment
Collaborator
There was a problem hiding this comment.
looks good, thanks Bao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Description
This PR covered:
requiresandproducesas instance-level variables for each hookidto each hook constructorRelated Issues: #381
Type of Change
Test Evidence
Describe how this PR has been tested.
Questions / Discussion Points
I will add this function to
BaseDGHook:I will refactor our code so we use this method every time we add a new attribute to the batch
This is a draft, and unit tests will be added to improve codecov.