Conversation
ntgbaoo
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Description
WIP
Related Issues: #35
Type of Change
Test Evidence
Describe how this PR has been tested.
Questions / Discussion Points
List any areas where you’d like reviewer input or have open questions.
Problem 1: node ID from a different table.
To solve this problem and make it work with TGM.
We need to go through the table.
If the table has a primary key, update it to make sure there is no ID overlap
If the table has no primary key, we need to add a primary key and ensure the node ID is continuous
In this case, we treat each table as a node type
Problem 2: misalignment between node features
Different tables/node types have different feature dimensions. Padding may work, but not
very memory efficient