Add More Integration tests - #49
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Jacob-Chmura
marked this pull request as ready for review
June 24, 2025 14:18
shenyangHuang
approved these changes
Jun 30, 2025
shenyangHuang
left a comment
shenyangHuang
left a comment
Collaborator
There was a problem hiding this comment.
approve with some items we can discuss
| '--time=0:10:00', | ||
| ] | ||
| ) | ||
| def test_edgebank_tgb_linkprop_pred(slurm_job_runner, dataset): |
Collaborator
There was a problem hiding this comment.
for integration tests, can't we just use a virtual environment that is setup already on disc and then all datasets will just be loaded? again, we can address this later
| @pytest.mark.parametrize('dataset', ['tgbl-wiki']) | ||
| @pytest.mark.slurm( | ||
| resources=[ | ||
| '--partition=main', |
Collaborator
There was a problem hiding this comment.
be aware, I think you can only launch a single job with --partition=main at mila at a given time
| @pytest.mark.parametrize('dataset', ['tgbl-wiki']) | ||
| @pytest.mark.slurm( | ||
| resources=[ | ||
| '--partition=main', |
Collaborator
There was a problem hiding this comment.
again, only a single main job at a time, other jobs will just pend until it finishes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to add more examples into our integration test pipeline. Moving forward, every new example script should be wrapped in an integration test, and we should ensure the default parameters run out of the box at all times.
Key Changes
mastertgbn-tradefor node prop prediction as it's much smallerRelevant Prs
Close #48
Out of scope