Skip to content

Run Integration Tests in Parallel - #54

Merged
Jacob-Chmura merged 57 commits into
mainfrom
ci/parallel_tests
Jun 30, 2025
Merged

Run Integration Tests in Parallel#54
Jacob-Chmura merged 57 commits into
mainfrom
ci/parallel_tests

Conversation

@Jacob-Chmura

@Jacob-Chmura Jacob-Chmura commented Jun 24, 2025

Copy link
Copy Markdown
Member

Purpose

The purpose of this PR is to dispatch all the integration tests at once on the cluster. In practice, we'll only get a 2x speedup since the scheduler limits each user to 2 GPUs at once.

Key Changes

  • add pytest-xdist as dev dependency
  • Rename slow pytest marker to integration for clarity
  • submit 2 concurrent integration tests at a time from the workflow file (no real reason to do more due to slurm constraints)
  • fix typo in TGN example script and TGAT test setup

Relevant Prs

Close #50

Out of scope

  • Parsing output log files to isolate the key metrics (performance and efficiency). I have this code working in one of my private repos

@Jacob-Chmura Jacob-Chmura self-assigned this Jun 24, 2025
@Jacob-Chmura
Jacob-Chmura changed the base branch from main to ci/add_integration_tests June 24, 2025 14:57
@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Jacob-Chmura
Jacob-Chmura marked this pull request as draft June 24, 2025 15:08
@Jacob-Chmura
Jacob-Chmura marked this pull request as ready for review June 24, 2025 15:32

- name: Run Integration Tests
run: uv run pytest test -m "slow" -vvv
run: uv run pytest -m "integration" -n 2 -vvv

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run's two jobs in parallel.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo caught while running the tests

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are working then :)

@shenyangHuang shenyangHuang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are working then :)

Base automatically changed from ci/add_integration_tests to main June 30, 2025 14:15
@Jacob-Chmura
Jacob-Chmura merged commit 7a8d5f7 into main Jun 30, 2025
6 checks passed
@Jacob-Chmura
Jacob-Chmura deleted the ci/parallel_tests branch June 30, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel Dispatch Integration Tests

2 participants