Update TGB TimeDelta Constants - #66
Merged
Merged
Conversation
shenyangHuang
approved these changes
Jun 30, 2025
|
|
||
| def test_tgb_native_time_deltas(): | ||
| exp_dict = { | ||
| 'tgbl-wiki': TimeDeltaDG('s'), |
Collaborator
There was a problem hiding this comment.
looks good to me, thanks for manually verifying
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In preparation for #40, I had a look at our TGB time granularities:
tgm/tgm/timedelta.py
Lines 78 to 99 in 5b4949e
These do not match the reported time granularities in the original data, which I have verified by manually loading in timestamps.
Solution
I fixed the time granularities. I also removed `'tkgl-' and 'thgl-' graphs as we don't support loading them at the moment.
Relevant Prs
Fix #65