Dockerfile CPU Smoke test fails to build torch - #74
Merged
Conversation
Jacob-Chmura
changed the title
Jacob-Chmura
marked this pull request as ready for review
June 27, 2025 11:47
shenyangHuang
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When changing moduel scope in our root package (#71) the eager import forced us to
import torchdirectly in the Dockefile smoke test. This uncovered the following error:Solution
The error was related to the fact that everything was installed in uv virtual environment instead of pip. To fix this, I went with full pip install so that CI passes. Also, that means users of the image can just work with python and avoid uv (in case they don't want it or have it).
Note: Also found an issue with the GPU dockerfile which has been resolved.
Relevant Prs
Fix #73
Out of scope