Refactor TGB Mock in Tests - #76
Merged
Merged
Conversation
shenyangHuang
approved these changes
Jul 1, 2025
| val_indices = np.arange(num_train, num_train + num_val) | ||
| test_indices = np.arange(num_train + num_val, num_events) | ||
| @pytest.fixture | ||
| def tgb_dataset_factory(): |
| val_mask = np.zeros(num_events, dtype=bool) | ||
| val_mask[val_indices] = True | ||
| def test_from_tgbl(mock_dataset_cls, tgb_dataset_factory, split, with_node_feats): | ||
| dataset = tgb_dataset_factory(split, with_node_feats) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to refactor the TGB mock dataset objects in our
DGData.from_tgbunit tests.Key Changes
from_tgbwhen working withNodePropdatasets, which occurs if there are no node events within a dataset split (e.g. no node features in validation set):I guarded this accordingly:
tgm/tgm/data.py
Lines 415 to 438 in 968ed03
Relevant Prs
Close #70