Deployment tab will now display whether TMs were added or updated #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d (no info for removed)
Cyberboss
requested changes
Mar 1, 2025
|
Retested |
Cyberboss
requested changes
Mar 2, 2025
auto-merge was automatically disabled
March 2, 2025 20:04
Head branch was pushed to by a user without write access
|
Retested again |
Cyberboss
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to tgstation/tgstation-server#2134 in that now the deployment tab will indicate when a TM is added, updated (or unchanged). It does not however list removed TMs as I felt it'd be a little too cluttered, and I'm content enough with discord bots having that information.
The pagination aspect of compile jobs complicated this however so there's a second query made for the additional CompileJob information I need for a page transition; and I'm not particularly interested in cross repo PRs (this repo ought to just be merged in to tgstation-server).
(I also tested when total job count wasn't a multiple of 5).