fix(mpris): keep MPRIS volume in sync with the actual volume #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JellyBrick
added
enhancement
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3225 by reverting some of the modifications from 9da0e43
The code introduced in that commit was meant to prevent a supposed recursion described in #1005 (comment), but I don't think it happens anymore (at least not in the current codebase, maybe it did in the past)
Now we can call this multiple times and it'll increment the volume properly (+10% volume per call)
playerctl --player=YoutubeMusic volume 0.1+Before, it would always get the same frozen volume and add 0.1 to it, so it would stop incrementing after the first call.