Skip to content

fix: Move the agent mode to the sdk - #329

Merged
hughneale merged 2 commits into
mainfrom
move-config-mode-to-sdk
May 8, 2026
Merged

fix: Move the agent mode to the sdk#329
hughneale merged 2 commits into
mainfrom
move-config-mode-to-sdk

Conversation

@hughneale

@hughneale hughneale commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR simply moves the thand mode into the SDK

Closes #


Type of Change

  • feat – New feature (minor version bump)
  • fix – Bug fix (patch version bump)
  • refactor – Code refactoring, no functional change
  • docs – Documentation only
  • test – Adding or updating tests
  • chore – Build, CI, dependency updates
  • major / BREAKING CHANGE – Breaking change (major version bump)

What Changed

A concise list of the changes made. Focus on the what and why, not the how.


Provider / Workflow / Role Changes

Complete this section if you've added or modified providers, workflows, or roles. Delete if not applicable.

Area Change Notes
Provider
Workflow
Role
  • Provider config files updated (config/providers/)
  • Role config files updated (config/roles/)
  • Workflow definitions updated (config/workflows/)
  • Example configs updated (examples/)

Security Considerations

This project handles privileged access. Describe any security implications of this change.

  • No security impact
  • Reviewed for least-privilege impact
  • Access grant / revocation logic reviewed
  • Audit trail is preserved for any new access paths
  • No credentials, tokens, or secrets introduced in code or config

Security notes (if applicable):


Testing

Describe how this was tested. Include commands if helpful.

  • Unit tests pass (go test ./...)
  • Functional tests pass
  • Integration tests pass
  • Manually tested locally — describe scenario below

Manual test scenario (if applicable):

# Describe the steps taken to verify the change works end-to-end

Breaking Changes

If this is a breaking change, describe the impact and any migration steps required.

  • This PR does not introduce breaking changes
  • This PR does introduce breaking changes (describe below)

Migration steps (if applicable):


Documentation

  • No documentation changes needed
  • In-code comments updated
  • docs/ updated
  • README.md updated
  • Config examples updated

Checklist

  • My branch is up to date with main
  • Commit messages follow the conventional commit format (feat:, fix:, major:, etc.)
  • No debug code, hardcoded values, or temporary workarounds left in
  • All new code has appropriate test coverage
  • I have reviewed my own diff before requesting review

Copilot AI review requested due to automatic review settings May 8, 2026 21:17
@hughneale hughneale added the fix Bug fix (patch version bump) label May 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the agent “mode” type/values in the SDK (via sdk/constants) and updates internal code/tests (and the CLI) to use the SDK-defined modes. It also includes a broad dependency refresh in both the main module and the test/ module.

Changes:

  • Added sdk/constants.Mode plus ModeServer/ModeAgent/ModeClient constants and updated sdk/config to reference them.
  • Updated internal/config to store/return sdk/constants.Mode and adjusted multiple unit tests and CLI wiring to pass SDK mode values.
  • Updated go.mod / go.sum (and test/go.mod / test/go.sum) with a large set of dependency version bumps.

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/constants/config.go Introduces SDK-owned Mode type and canonical mode constants.
sdk/config/model.go Re-exports Mode from sdk/constants and continues exposing SDK config types.
internal/config/model.go Switches internal config mode storage/APIs to sdk/constants.Mode and updates request structs accordingly.
cmd/cli/main.go Updates CLI pre-run mode selection to use SDK mode constants/types.
internal/daemon/provider_cookies_test.go Updates cookie server tests to use SDK mode constants/types.
internal/config/*_test.go Updates config-related tests to use SDK mode constants.
internal/api/elevate_test.go Updates elevate API tests to set mode using SDK constants.
go.mod / go.sum Updates a wide range of dependencies (AWS SDK, Temporal, gRPC, etc.).
test/go.mod / test/go.sum Updates integration-test module dependencies to match bumped versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/config/model.go
Comment thread sdk/config/model.go
@hughneale
hughneale merged commit 71afe04 into main May 8, 2026
14 checks passed
@hughneale
hughneale deleted the move-config-mode-to-sdk branch May 8, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix (patch version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants