Skip to content

Add support for labelNames and labelValues #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vCra
Copy link

@vCra vCra commented Oct 5, 2024

Fixes the labelValues and labelNames part of #5

Does not add support for Series

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Did you get a chance to test this manually?

Add implementation of store server to enable labelNames and labelValues

Undo ignoring .idea folder
@vCra vCra force-pushed the feature/vCra-labelName-labelValue branch from 8a5742d to 9f17c73 Compare December 9, 2024 17:42
Copy link

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@sarthaktyagi-505
Copy link

sarthaktyagi-505 commented Apr 24, 2025

Hi Guys,

I am trying to extend this connector to also use Series endpoint, Now I have read previous comments and Series is a heavy call but I was wondering, that we might also extend a capability of aggregating the data from various sources (which is doesnt happen right now if I am not wrong). Am I correct to assume that if we have both store and query servers running as part of this, the query in thanos distributed mode will be able to use either of them depending on if the query is split or not?

We just tried to use thanos-sidecar for this purpose but since sidecar is only storeAPI every call is a remote_read which makes querying through it really slow. What do you guys think?

@fpetkovski
Copy link
Contributor

Hi @sarthaktyagi-505, the Series call should not be needed for aggregating data between two query nodes. The proxy will distribute the query to both nodes and aggregate data centrally. Perhaps something is not properly configured in your setup if you are unable to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants