Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config#227
Open
ulfmansson wants to merge 4 commits intothanos-io:mainfrom
Open
Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config#227ulfmansson wants to merge 4 commits intothanos-io:mainfrom
ulfmansson wants to merge 4 commits intothanos-io:mainfrom
Conversation
Support for tls secure requests Signed-off-by: ulfmansson <ulf.mansson@adfenix.com>
Added comment about --grpc-client-tls-secure Signed-off-by: ulfmansson <ulf.mansson@adfenix.com>
Fixed to follow changelog format Signed-off-by: ulfmansson <ulf.mansson@adfenix.com>
Contributor
|
Maybe this can be updated to be closer to this using a boolean? if tq.config.autoDownsampling then [
'--query.auto-downsampling',
] else [] |
Updated to nicer structure after comment in PR Signed-off-by: ulfmansson <ulf.mansson@adfenix.com>
Author
|
Updated according to the comment |
kakkoyun
changed the title
Member
|
Shall we rebase this? Then we can proceed. |
|
Any update on this? |
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config
Verification
Run with both grpcClientTlsSecure set and unset