Skip to content

receive: Removing version from label selector so that version updates are working#289

Open
pjastrzabek-roche wants to merge 1 commit intothanos-io:mainfrom
pjastrzabek-roche:label-selector-fix
Open

receive: Removing version from label selector so that version updates are working#289
pjastrzabek-roche wants to merge 1 commit intothanos-io:mainfrom
pjastrzabek-roche:label-selector-fix

Conversation

@pjastrzabek-roche
Copy link
Copy Markdown

Removing version from label selector so that version updates are working.

Currently it would throw an error like:

Deployment/thanos/thanos-receive-router dry-run failed, reason: Invalid, error: Deployment.apps "thanos-receive-router" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"thanos-receive-router", "app.kubernetes.io/instance":"thanos-receive", "app.kubernetes.io/name":"thanos-receive", "app.kubernetes.io/version":"v0.29.0"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Signed-off-by: pjastrzabek-roche 105636104+pjastrzabek-roche@users.noreply.github.com

Removing version from label selector so that updates of that components are working.

Signed-off-by: pjastrzabek-roche <105636104+pjastrzabek-roche@users.noreply.github.com>
@pjastrzabek-roche
Copy link
Copy Markdown
Author

what exactly is wrong with that build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant