Skip to content

adding networkpolicy for thanos components#315

Open
harsh-ps-2003 wants to merge 3 commits intothanos-io:mainfrom
harsh-ps-2003:networkpolicy
Open

adding networkpolicy for thanos components#315
harsh-ps-2003 wants to merge 3 commits intothanos-io:mainfrom
harsh-ps-2003:networkpolicy

Conversation

@harsh-ps-2003
Copy link
Copy Markdown

@harsh-ps-2003 harsh-ps-2003 commented Jan 6, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #314
Adding network policies for all Thanos components.

Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
Copy link
Copy Markdown
Author

@metalmatze can you review the PR please. If it looks good I will add the changelog.

@metalmatze
Copy link
Copy Markdown
Contributor

Thanks!
From looking at the code changes and now having compiled and run this, the change seems good overall. 👍

Some CI failures need to be fixed. Run jsonnetfmt -i $file on your changed files.

Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
Copy link
Copy Markdown
Author

Thanks for the review! I had some syntax errors that I fixed now! @metalmatze

Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NetworkPolicy to all components

2 participants