compact: Add securityContext to Thanos compact container#333
Open
kaznak wants to merge 2 commits intothanos-io:mainfrom
Open
compact: Add securityContext to Thanos compact container#333kaznak wants to merge 2 commits intothanos-io:mainfrom
kaznak wants to merge 2 commits intothanos-io:mainfrom
Conversation
kaznak
added a commit
to kaznak/kube-thanos
that referenced
this pull request
Nov 10, 2025
kaznak
added a commit
to kaznak/kube-thanos
that referenced
this pull request
Nov 10, 2025
Signed-off-by: kaznak <kaznak.at.work@ipebble.org>
Signed-off-by: kaznak <kaznak.at.work@ipebble.org>
3e729af to
ee89f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
kube-thanos-compact-default-params.libsonnetfile already defines asecurityContextContainerparameter, but it is not currently used.kube-thanos/jsonnet/kube-thanos/kube-thanos-compact-default-params.libsonnet
Lines 52 to 60 in 6fedb04
Because of this missing reference, the generated manifests trigger Pod Security Admission warnings or may even be rejected under restricted policies.
This PR applies the
securityContextContainerparameter to the compact container so that the generated manifests comply with restricted PodSecurity standards.Verification
I applied the manifests generated from this branch to my cluster, and the Pod Security Admission warning was successfully suppressed.