engine,execution: make remote endpoints injectable #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoints-a-query-parameter
branch
2 times, most recently
from
4422ae1 to
90ae2ef
Compare
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoints-a-query-parameter
branch
from
90ae2ef to
44837de
Compare
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoints-a-query-parameter
branch
from
44837de to
9f751d2
Compare
MichaHoffmann
commented
Feb 21, 2025
| // Distributed constructors | ||
|
|
||
| // MakeDistributedInstantQuery creates an instant query that is distributed among the passed endpoints. | ||
| func (e *Engine) MakeDistributedInstantQuery(ctx context.Context, q storage.Queryable, endpoints api.RemoteEndpoints, opts *QueryOpts, qs string, ts time.Time) (promql.Query, error) { |
There was a problem hiding this comment.
q is actually used by distriubted engine sometimes - it feels like a bug, but fixing is out of scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes remote endpoints injectable into the distributed engine - this makes it possible to provide endpoints that are configured at runtime - the usecase for this is for example "partial_response" query parameter handling in Thanos.
This mirrors how queryable is passed in at runtime to construct non-distributed queries.