engine: remove implicit fallback #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/remove-implicit-fallback
branch
2 times, most recently
from
df6e098 to
f13566a
Compare
MichaHoffmann
force-pushed
the
mhoffmann/remove-implicit-fallback
branch
from
f13566a to
d7e66d4
Compare
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/remove-implicit-fallback
branch
from
d7e66d4 to
479ebed
Compare
saswatamcode
approved these changes
Feb 20, 2025
| @@ -6,7 +6,7 @@ The project is currently under active development. | |||
|
|
|||
| ## Roadmap | |||
|
|
|||
| The engine intends to have full compatibility with the original engine used in Prometheus. Since implementing the full specification will take time, we aim to add support for most commonly used expressions while falling back to the original engine for operations that are not yet supported. This will allow us to have smaller and faster releases, and gather feedback on a regular basis. Instructions on using the engine will be added after we have enough confidence in its correctness. | |||
| The engine intends to have full compatibility with the original engine used in Prometheus. Since implementing the full specification will take time, we aim to add support for most commonly used expressions. Instructions on using the engine will be added after we have enough confidence in its correctness. If the engine encounters an expression it does not support it will return an error that can be tested with `engine.IsUnimplemented(err)`, the calling code is expected to handle this fallback. | |||
There was a problem hiding this comment.
Hmm I wonder if we can use some other term than "confidence in its correctness". I think the tests speak to that :)
fpetkovski
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to do in cases where this engine does not understand the query should be decided in the calling code. Taking this responsibility of the engine also forces us to deal with queries that we do not understand explicitly in acceptance tests ( by skipping them ) without accidentally falling back.
It also makes the code and test surface a bit smaller for the engine.