Do not return pointers from windowing functions #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
remove-float-pointers
branch
3 times, most recently
from
54d96ef to
0912d78
Compare
MichaHoffmann
approved these changes
Feb 20, 2025
fpetkovski
force-pushed
the
remove-float-pointers
branch
2 times, most recently
from
15b68b7 to
614a1b2
Compare
Commit c2f322e introduced large regressions since due to two changes: * Changed return values of windowing functions from float64 to *float64, causing excessive allocations. * Added an expensive check on the hot path for a condition that could be calculated once for the entire query. This commit reverts that changes and adds a better way to handle cases where both float and histogram values are missing, but there is no error in the evaluation. Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
remove-float-pointers
branch
from
614a1b2 to
29c49d7
Compare
yeya24
approved these changes
Feb 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c2f322e introduced large regressions since due to two changes:
This commit reverts that changes and adds a better way to handle cases where both float and histogram values are missing, but there is no error in the evaluation. We can easily do this by returning a boolean value.
BenchmarkSingleQueryresult@SungJin1212 @yeya24 could you take a look?