Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: make logical optimizers configurable at querytime #520

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Feb 24, 2025

This PR makes Optimizers configurable at query time, which allows to also specify the remote optimizers at runtime. This makes the distributed engine a special case of the core engine by overriding optimizers. Partial Response handling is also obsolete since that can be injected into the distributed optimizer via special endpoints implementations.

@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/make-logical-optimizers-configurable-at-runtime-remove-distributed-engine branch 4 times, most recently from a3d4b07 to 4b55c7d Compare February 25, 2025 11:44
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/make-logical-optimizers-configurable-at-runtime-remove-distributed-engine branch from 4b55c7d to 50c8de7 Compare February 25, 2025 11:44
@MichaHoffmann MichaHoffmann marked this pull request as ready for review February 25, 2025 11:56
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/make-logical-optimizers-configurable-at-runtime-remove-distributed-engine branch from f341fc8 to 184d42e Compare February 25, 2025 12:45
@MichaHoffmann MichaHoffmann changed the title engine: make logical optimizers configurable at querytime, remove distributed engine struct engine: make logical optimizers configurable at querytime Feb 25, 2025
Signed-off-by: Michael Hoffmann <[email protected]>
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/make-logical-optimizers-configurable-at-runtime-remove-distributed-engine branch from 184d42e to f54792f Compare February 28, 2025 10:05
@MichaHoffmann MichaHoffmann merged commit 31bfaeb into main Feb 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants