execution: dont reset aggregation hints in call #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichaHoffmann
commented
Mar 6, 2025
•
MichaHoffmann
commented
We would like to have grouping hints in select calls for expressions like "sum by (foo) (rate(metric[5m]))" too. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/dont-reset-aggregtaion-hints-in-call
branch
from
23c4f4f to
3924c6d
Compare
|
Note - this is tricky because "topk(10, X)" ~ has all labels; "sum(X)" ~ has no labels; both have same groupings; meaning that we cannot use this for projection hints. topk(10, rate(X[5m])) ~ has all labels still same grouping hints are set for both |
|
I think this is not well defined sadly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.