Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
max_sampleslimit enforcement to prevent OOM by tracking samples at the operator level.Changes:
SampleTrackerinquery/package withAdd(),Remove(), andCheckLimit()methodsMaxSamplesfield toEngine.Opts(default 0 = unlimited)ErrMaxSamplesExceedederror for limit violationsTracking Implementation:
Uses delta-based tracking (similar to
peak_samplespattern) in three operators:Operator queries
buffer.SampleCount(), compares to previous count, and tracks the delta usingAdd()/Remove().