execution: batch by series optimization for matrix selectors with high window overlap #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores using a series-batching optimization to reduce peak
RingBuffermemory usage for queries with long lookback windows and high cardinality.Problem: Queries like
sum(increase(metric[24h]))with a small step size create relatively large ring buffer for matrix selectors. This is done once per series and can quickly bloat memory causing OOM for high cardinality queries.Solution: When matrix selector window overlap exceeds a certain number of steps (example 100), the optimizer switches from step batching to series batching:
Changes:
This PR is work in progress... The main blocker is validating that series batching can work for certain functions/operators that need all series present for execution