feat: update TSDB block meta extensions field when converted to parquet#14
Open
verejoel wants to merge 4 commits intothanos-io:mainfrom
Open
feat: update TSDB block meta extensions field when converted to parquet#14verejoel wants to merge 4 commits intothanos-io:mainfrom
verejoel wants to merge 4 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
verejoel
force-pushed
the
feature/migration-path
branch
from
9db3485 to
de5276b
Compare
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
verejoel
force-pushed
the
feature/migration-path
branch
from
527e0cd to
5341da1
Compare
2 tasks
GiedriusS
reviewed
Jul 10, 2025
GiedriusS
reviewed
Jul 10, 2025
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
reviewed
Nov 6, 2025
| // ParquetMigratedExtensionKey is the key used in TSDB block metadata Extensions | ||
| // to indicate that the block has been migrated to Parquet format. | ||
| // TODO: Import this constant from Thanos when it becomes available in their metadata package. | ||
| ParquetMigratedExtensionKey = "parquet_migrated" |
Member
There was a problem hiding this comment.
Member
|
I'm afraid this is a bit harder than it looks like - if the converter process crashes right before this marking then the blocks are successfully converted but on the other side meta.json doesn't have that marker. Instead I suggest doing a different thing - in meta.pb track the list of ULIDs from which that Parquet block was converted and read them from the original Thanos Store instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11 .
I also added support for this new flag in Thanos: thanos-io/thanos#8366