feat: Added support for AWS auth flags and dynamic hashed external-label block paths#18
Draft
TaranpreetSingh wants to merge 2 commits intothanos-io:mainfrom
Draft
feat: Added support for AWS auth flags and dynamic hashed external-label block paths#18TaranpreetSingh wants to merge 2 commits intothanos-io:mainfrom
TaranpreetSingh wants to merge 2 commits intothanos-io:mainfrom
Conversation
added 2 commits
September 23, 2025 19:31
adding the label sharding support See merge request cti/rokumesh-observability/thanos-parquet-gateway!4 Signed-off-by: Taranpreet Singh <tsingh@roku.com>
Added support for AWS auth flags and dynamic hashed external-label block paths Signed-off-by: Taranpreet Singh <tsingh@roku.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Hashed external-label path component: when an external label matcher is present its first value is SHA-256 hashed (hex) and inserted as an extra directory level ([yyyy/mm/dd//]), while legacy layout ([yyyy/mm/dd/]) remains valid.
Helper to split block paths that supports both legacy and hashed layouts.
Flags to enable AWS SDK auth for Parquet and TSDB buckets:
--parquet.storage.s3.aws-sdk-auth
--tsdb.storage.s3.aws-sdk-auth
Changed
Block name generation now accepts an [externalLabelValue] to optionally produce the hashed layout.
Conversion pipeline extracts the first external label matcher value, hashes it (full SHA-256 hex), and uses it for naming.