convert: add backlog conversion date limit#46
Open
yuchen-db wants to merge 3 commits intothanos-io:mainfrom
Open
convert: add backlog conversion date limit#46yuchen-db wants to merge 3 commits intothanos-io:mainfrom
yuchen-db wants to merge 3 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Yuchen Wang <yuchen.wang@databricks.com>
Signed-off-by: Yuchen Wang <yuchen.wang@databricks.com>
Signed-off-by: Yuchen Wang <yuchen.wang@databricks.com>
MichaHoffmann
approved these changes
Jan 9, 2026
GiedriusS
reviewed
Jan 22, 2026
| type Planner struct { | ||
| // Do not create parquet blocks that are younger then this. | ||
| notAfter time.Time | ||
| // Do not create parquet blocks that are older then this. |
| if opts.maxDaysBack > 0 { | ||
| notBefore = time.Now().AddDate(0, 0, -opts.maxDaysBack).Truncate(24 * time.Hour) | ||
| } | ||
| plan := convert.NewPlanner(notAfter, notBefore, opts.maxDays).Plan(tsdbMetas, parquetMetas) |
Member
There was a problem hiding this comment.
Could values of notAfter, notBefore be logged, please?
MichaHoffmann
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we ran into disk full issue converting backlogs that are already compacted to 14-day blocks. adding this flag to limit how far we go back