feat: support block lineage checks to reduce redundant conversion#5
Draft
verejoel wants to merge 2 commits intothanos-io:mainfrom
Draft
feat: support block lineage checks to reduce redundant conversion#5verejoel wants to merge 2 commits intothanos-io:mainfrom
verejoel wants to merge 2 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
verejoel
force-pushed
the
feature/block-lineage
branch
from
7301761 to
52cb78e
Compare
GiedriusS
reviewed
Jul 8, 2025
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
What are the use case(-s) where we would not want this enabled all the time? 🤔
Contributor
Author
That's a fair point, tbh I want to get the idea/approach validated first. I'm a bit hesitant to break/change how things work as well (although at this point we probably don't need to care so much about backwards compatibility). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If blocks A and B have already been converted to parquet, then get compacted into C, we should exclude C from being converted again.