Propagate logger and metric registry into promql engine#83
Open
ringerc wants to merge 1 commit intothanos-io:mainfrom
Open
Propagate logger and metric registry into promql engine#83ringerc wants to merge 1 commit intothanos-io:mainfrom
ringerc wants to merge 1 commit intothanos-io:mainfrom
Conversation
The Thanos PromQL engine was being initialized without any logger or any metric registry so it wasn't able to expose metrics about its own execution into the parquet gateway or correctly log with severity filtering. A test is added to validate the metric integration. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
ringerc
force-pushed
the
fix-missing-promql-metrics
branch
from
b203f47 to
ab2a2b3
Compare
MichaHoffmann
approved these changes
Mar 19, 2026
Author
|
Thanks. Looks like I don't have permission to trigger a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Thanos PromQL engine was being initialized without any logger or any metric registry so it wasn't able to expose metrics about its own execution into the parquet gateway or correctly log with severity filtering.
Fix by passing the parquet-gateway's logger and metric registry to the engine.
A test is added to validate the metric integration.