convert: add option to skip replica labels#89
Open
alxric wants to merge 2 commits intothanos-io:mainfrom
Open
Conversation
alxric
force-pushed
the
alex/drop_replica_label
branch
5 times, most recently
from
f3dff69 to
2a8cb5e
Compare
Signed-off-by: Alexander Rickardsson <alxric@aiven.io>
alxric
force-pushed
the
alex/drop_replica_label
branch
from
2a8cb5e to
2df08c9
Compare
GiedriusS
reviewed
Mar 30, 2026
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
@MichaHoffmann does this solve the issue we talked about on Slack?
Signed-off-by: Alexander Rickardsson <alxric@aiven.io>
Collaborator
Yes I think so! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This to avoid creating multiple folders in case the converter is being run against blocks that still have this external label in the metadata.