bump thanos and update hints in Series call to respect project info passed by client#91
Open
Saumya40-codes wants to merge 1 commit intothanos-io:mainfrom
Open
Conversation
…assed by client upd Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Saumya40-codes
force-pushed
the
respect-proj-hints-in-series-call
branch
from
06ef764 to
68e4fb8
Compare
Saumya40-codes
commented
Apr 1, 2026
Comment on lines
+262
to
+266
| if v := seriesChunks[i].Lset.Get(schema.SeriesHashLabel); v != "" { | ||
| if len(v) == 8 { | ||
| h = binary.LittleEndian.Uint64([]byte(v)) | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Was preferring hash label here (re: #82 (comment)) during dedup during projection, though won't seriesChunks[i].LsetHash will be unique for the series as we recalculate hash with __cf_series_hash__ present at https://github.com/thanos-io/thanos-parquet-gateway/blob/main/search/materialize.go#L77 ?
bit unsure here as when this check is required thus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #82
This pr bump thanos to commit thanos-io/thanos@38129bb
where storeAPIs were updated to propogate projection labels in PR (thanos-io/thanos#8625)
In series call it checks whether projections are set, if it is then updates Storage.SelectHints so it can be used in downstream with honorProjection already in-place. Where if its used, it only loads the labels set via
ProjectionLabels []stringand a__cf_series_hash__is added with previous implementation.