Update parquet gateway to Prometheus 3.11 without nocopy patch#95
Draft
ringerc wants to merge 11 commits intothanos-io:mainfrom
Draft
Update parquet gateway to Prometheus 3.11 without nocopy patch#95ringerc wants to merge 11 commits intothanos-io:mainfrom
ringerc wants to merge 11 commits intothanos-io:mainfrom
Conversation
Add Thanos-compatible --tracing.config and --tracing.config-file support for configuring tracing. Deprecate the existing Jaeger config flags. As Thanos lacks support for the STDOUT trace destination, support for it is omitted from the file-based trace configuration. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Memoizing tracer creation with sync.OnceValue could race with tracer configuration loading and initialization, unintentionally caching the no-op tracer. There's little to no benefit in caching the tracer anyway. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
This drops support for the STDOUT tracer as the Thanos file loader doesn't support it. If anyone cares, we could add a stdout provider to the Thanos file based tracer loader. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Add new "query.expr" trace span attribute to thanos.Query/QueryRange gRPC trace event, to record the query-text in the incoming query. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Add result.series and result.samples counts to the trace events for Query gRPC responses. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Add result.series and result.samples span attributes to Series gRPC response trace events. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Add a series.matchers attribute to trace spans for Series gRPC requests. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #94 but adopts upstream prometheus directly, without the nocopy patch (prometheus/prometheus#18393)