Skip to content

build(deps): update objstore to the latest #8162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tritone
Copy link

@tritone tritone commented Mar 17, 2025

Updates objstore to HEAD. Also transitively picks up updates for the GCS SDK (see thanos-io/objstore#165).

Also removes replace statement pinning google.golang.org/grpc. Issue which was referenced in the comment (grpc/grpc-go#7314) is now resolved.

I had to make the following additional changes to handle breaking changes in dependencies:

  • Pin github.com/prometheus/common to v0.62.0 because of a breaking change in the following version. This is a direct dependency so work is required in this repo to unpin.
  • Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace to the latest release in order to resolve a breaking change in an indirect dep.
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

make deps and make build pass locally. I could use some help debugging the presubmit failures.

Updates objstore to HEAD. Also transitively picks up updates
for the GCS SDK (see #thanos-io/objstore#165).

Also removes replace statement pinning google.golang.org/grpc.
Issue which was referenced in the comment (#grpc/grpc-go#7314)
is now resolved.
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 24, 2025
@tritone tritone changed the title Update objstore to the latest build(deps): update objstore to the latest Mar 24, 2025
@bwplotka
Copy link
Member

Unfortunately there was a breaking change in the main package in objstore: thanos-io/objstore#155

@fpetkovski might have more context, but we need manual changes to fix this.

@tritone do you want to take a stab on resolving? If not, perhaps one of the @thanos-io/thanos-maintainers has time to do the refactor.

@fpetkovski
Copy link
Contributor

We added a new method to the interface, so we probably need to propagate that to all implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants