Skip to content

e2e: basic utf8 test #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

e2e: basic utf8 test #8171

wants to merge 1 commit into from

Conversation

MichaHoffmann
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@MichaHoffmann
e2e: basic utf8 tests
96f6f2f 
Signed-off-by: Michael Hoffmann <[email protected]>
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/e2e-basic-utf8-test branch from a93115b to 96f6f2f Compare March 25, 2025 06:44
yeya24
yeya24 reviewed Mar 25, 2025
View reviewed changes
test/e2e/query_test.go
},
Value: model.SampleValue(2),
Timestamp: model.TimeFromUnixNano(now.Add(time.Minute).UnixNano()),
}}, retv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more APIs like label names and label values, to make sure they also work as expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need some special handling for label values API prometheus/prometheus#15399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaHoffmann @yeya24