Support to adjust the maximum open files on containerize env #8208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntk148v
force-pushed
the
feat/ulimit
branch
4 times, most recently
from
f6a761e to
b0e9a6d
Compare
GiedriusS
reviewed
Apr 25, 2025
GiedriusS
reviewed
Apr 25, 2025
Enable users to modify the maximum number of open file descriptors by setting the THANOS_ULIMIT_NOFILES environment variable as in Kubernetes environment, adjusting this value can be challenging. Signed-off-by: Kien Nguyen Tuan <[email protected]>
|
@GiedriusS I've added a testcase for this, set an extremely low value to expect an error when be firing. |
Signed-off-by: Kien Nguyen Tuan <[email protected]>
|
@GiedriusS some test cases are randomly failed, I can't figure out why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable users to modify the maximum number of open file descriptors by setting the THANOS_ULIMIT_NOFILES environment variable, as in Kubernetes environment, adjusting this value can be challenging.