receive: Return most common err instead on writeErr cause#8741
Draft
saswatamcode wants to merge 1 commit intothanos-io:mainfrom
Draft
receive: Return most common err instead on writeErr cause#8741saswatamcode wants to merge 1 commit intothanos-io:mainfrom
saswatamcode wants to merge 1 commit intothanos-io:mainfrom
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
force-pushed
the
writecause
branch
from
42c31a5 to
dc1fedd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #8727
The added writeError test fails on current main as it returns errUnavailable on 409 + 409 + 503.
Which is sort of wrong, as an rw req with 409 on both will never achieve quorum anyway, even after remaining rep comes back up.
Changes
Verification