receive: enable ExportCreatedMetric in OTLP translator#8766
Open
alliasgher wants to merge 1 commit intothanos-io:mainfrom
Open
receive: enable ExportCreatedMetric in OTLP translator#8766alliasgher wants to merge 1 commit intothanos-io:mainfrom
alliasgher wants to merge 1 commit intothanos-io:mainfrom
Conversation
Without ExportCreatedMetric, the StartTimeUnixNano field on OTLP counters and histograms was silently dropped during translation to Prometheus remote write. This broke counter reset detection for downstream systems that rely on the _created timestamp to distinguish a genuine counter reset from a fresh series. Setting ExportCreatedMetric: true in the otlptranslator.Settings causes the translator to emit a <metric>_created series carrying the StartTimeUnixNano value, matching the behaviour described in the Prometheus exposition format spec. Fixes thanos-io#8637 Signed-off-by: Ali <alliasgher123@gmail.com>
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Without
ExportCreatedMetric, theStartTimeUnixNanofield on OTLP counters and histograms was silently dropped during translation to Prometheus remote write. This breaks counter reset detection for downstream systems that rely on the_createdtimestamp to distinguish a genuine counter reset from a fresh series.Setting
ExportCreatedMetric: trueinotlptranslator.Settingscauses the translator to emit a<metric>_createdseries carrying theStartTimeUnixNanovalue, matching the behaviour described in the Prometheus exposition format spec.Fixes #8637
Checklist
go test ./pkg/receive/passesgofmtcleanpkg/receive/writecapnpis unrelated (also fails on unmodifiedmain)Signed-off-by: Ali alliasgher123@gmail.com