bucketweb: display block labels on each source row#8816
Conversation
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Generally code LGTM, but would be great if you could share a screenshot!
Also, @kimjune01 could you sign the commit?
kimjune01
force-pushed
the
fix-8506-bucketweb-labels-visible
branch
2 times, most recently
from
d9b78a8 to
49056a2
Compare
|
The React UI test failure is from pre-existing lint warnings in |
Ruler doesn't set PartialResponse for gRPC clients, so it's always false. It only sets it for HTTP clients. > Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
Show thanos.labels for each source group directly in the bucket web UI, so users can identify which cluster/environment blocks belong to without clicking through to the block details panel. Fixes thanos-io#8506 Signed-off-by: June Kim <kimjune01@gmail.com>
Signed-off-by: June Kim <kimjune01@gmail.com>
Signed-off-by: June Kim <kimjune01@gmail.com>
Signed-off-by: June Kim <kimjune01@gmail.com>
Change label color from thanos-io#555 to #aaa so badges are readable on both light and dark backgrounds. Signed-off-by: June Kim <kimjune01@gmail.com>
Use scripts/build-react-app.sh (PUBLIC_URL=.) to match CI expectations. Signed-off-by: June Kim <kimjune01@gmail.com>
kimjune01
force-pushed
the
fix-8506-bucketweb-labels-visible
branch
from
e83a848 to
d0e67c2
Compare
|
The Netlify deploy preview failures (header rules, redirect rules, pages changed) appear to be infrastructure issues — other recent PRs on this repo pass Netlify fine. Happy to investigate further if needed, but these don't seem related to the React UI changes in this PR. |
|
Added screenshots (dark + light) and signed the commits. Thanks for the review! |
|
The unit test failure is a goroutine leak in pkg/receive (goleak detecting a stuck fanoutForward goroutine) — unrelated to the CSS change here. Main branch shows the same flaky failure on recent commits (e.g. May 7, May 6). Happy to rebase if a re-run would help, but I can't trigger one myself. |
Background investigations the substrate ran during this session. Modified existing graphs (envoyproxy/envoy, pymc-devs/pymc, ratatui/ratatui) and new graphs for: IBM/mcp-cli#242, MaterializeInc/materialize#36491, flux-rs/flux#1595, gluesql/gluesql#1912, microsoft/aici#122, njbrake/agent-of-empires (#1176, #1177), pingcap/tidb#68379, pingcap/tiflash#10845, pola-rs/polars#27592, pylint-dev/pylint#11002, thanos-io/thanos#8816, triton-lang/triton#10278, vllm-project/vllm#42174, wiiznokes/fan-control#247. Pure artifact commit — these accumulate as pipeline output; not authored in this conversation. Committing now so the working tree is clean before the next session.
|
Cannot validate on current setup, so drafting. Please close or take it over. |
3 participants
Closes #8506
Changes
Each source row in the Bucket Web UI now displays block labels inline, so users can identify sources (e.g. by cluster, environment) without clicking into individual blocks.
getLabelsFromPoolhelper inSourceView.tsxto extract labels from the first available block in a source's pool.sourceLabels/.labelBadgeCSS classes for layout and stylingSourceView.test.tsxto assert labels are visible on each rowVerification
cd pkg/ui/react-app && CI=true npx react-scripts test -- --watchAll=falsepassesmonitor="foo") now appear on every source row in the blocks page