receive: validate grpc remote write tenant#8817
Open
officialasishkumar wants to merge 3 commits into
Open
Conversation
GiedriusS
reviewed
May 18, 2026
GiedriusS
left a comment
Member
There was a problem hiding this comment.
Could you please refactor so the same GetTenantFromHTTP could be reused? I think we can just remove *http.Request there and pass some generic types.
Author
|
Done in 0a7cb2f: |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
0a7cb2f to
00b3c95
Compare
Author
|
Refactored the gRPC tenant validation to reuse GetTenantFromHTTP through a generic header getter in 00b3c95. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #8812.
InvalidArgumentfor invalid tenant values instead of using them to select or create TSDB directories.Verification
go test -tags slicelabels ./pkg/receive -run 'TestReceiveGRPCTenantValidation|TestTenantFromWriteRequest|TestReceiveTenantValidation|TestHandlerSplitTenantLabelLocalWrite|TestReceiveQuorumHashmod|TestReceiveQuorumKetama' -count=1