feat(ui/bucketweb): show block labels in span tooltip on hover#8856
Open
BRGOVIND wants to merge 4 commits into
Open
feat(ui/bucketweb): show block labels in span tooltip on hover#8856BRGOVIND wants to merge 4 commits into
BRGOVIND wants to merge 4 commits into
Conversation
Hovering over a block span in the timeline now shows a native browser
tooltip with the block ULID on the first line and its thanos labels
(`{key="value", ...}`) on the second line.
Previously the only way to see a block's labels was to click the span
and open the BlockDetails side panel, which is disruptive when scanning
many blocks.
The new `blockTooltip` helper renders the ULID + label-set in
Prometheus label syntax. Blocks with no labels show only the ULID.
No layout changes required.
Fixes thanos-io#8506
Signed-off-by: B R GOVIND <brgovind2005@gmail.com>
Regenerate pkg/ui/static/react/ to include the updated JS bundle produced by adding the blockTooltip helper and title attribute to BlockSpan.tsx. Built with Node 14 to match CI environment. Signed-off-by: B R GOVIND <brgovind2005@gmail.com>
Rebuild pkg/ui/static/react/ using Node 14 inside a Docker container with a Linux git clone, matching the exact CI environment. This fixes the CSS source map content which previously had CRLF line endings from a Windows-mounted Docker build. Signed-off-by: B R GOVIND <brgovind2005@gmail.com>
Signed-off-by: B R GOVIND <brgovind2005@gmail.com>
Author
|
Friendly ping — this is a small UI-only change that surfaces block labels in the bucket-web span tooltip on hover. CI is green. Happy to rebase or tweak the UX if a maintainer has a chance to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the bucketweb block timeline, hovering over a block span shows no information. Users must click each block to open the
BlockDetailsside panel to see itsthanos.labels— an unnecessary interruption when scanning a large number of blocks.Fixes #8506
Solution
Add a native
titletooltip to eachBlockSpanbutton. On hover the browser shows:The ULID is always shown; the label set appears on the second line in Prometheus label syntax. Blocks with no labels show only the ULID.
A small
blockTooltip()helper builds the string — no third-party tooltip library required.Files changed
pkg/ui/react-app/src/thanos/pages/blocks/BlockSpan.tsxblockTooltip()helper andtitleprop to the block buttonTesting
make ui-buildand start the bucket web UI connected to an object store.thanos.labelsshow only the ULID.Signed-off-by: B R GOVIND brgovind2005@gmail.com