fix(exceptions): redact device address from connection error messages - #374
Open
WilhelmZA wants to merge 1 commit into
Open
fix(exceptions): redact device address from connection error messages#374WilhelmZA wants to merge 1 commit into
WilhelmZA wants to merge 1 commit into
Conversation
WilhelmZA
force-pushed
the
pr/error-sanitization
branch
from
June 14, 2026 11:11
6cec706 to
5fe8160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection-related errors (
ScrapeError,AuthError,RestError,DeviceTimeout) surface netmiko's raw message, which includes aDevice settings:line exposing the device's IP address and port. This strips that line before the error reaches the client (falling back to a generic message if nothing else remains), so internal device addressing isn't leaked to looking-glass end users.Standalone fix — touches only
hyperglass/exceptions/public.py; independent of the structured-output PR series.