[add] gogo benchmark#9390
Open
7elven wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
GET /returns 200 with an empty bodyGET /user/:idreturns the route parameterPOST /userreturns 200 with an empty bodygogoGo engine so the benchmark generator can select a framework-specific Dockerfile.go/gogo.Dockerfilethat enables cgo, installs native zlib build headers, builds with thegogotag, and installs runtime libraries needed by the native binary.Validation
gofmt -w go/gogo/main.gogit diff --cached --checkruby -ryaml -e 'ARGV.each { |f| YAML.safe_load(File.read(f)); puts "ok #{f}" }' go/config.yaml go/gogo/config.yamlCGO_ENABLED=1 go test -tags gogo ./...in the gogo source checkoutCGO_ENABLED=1 go run -mod=mod -tags gogo .fromgo/gogo, then checked:GET /-> 200, empty bodyGET /user/0-> 200, body0POST /user-> 200, empty bodyNotes
I could not run
bundle exec rake configor a Docker build locally because this machine only has macOS system Ruby 2.6 for the repo's Ruby 3+ rake code and does not have Docker installed. The PR is opened as a draft so CI can validate the generated Docker path before review.