Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MF] styling list and items pages #90

Merged
merged 26 commits into from
Apr 6, 2024
Merged

Conversation

krsnamara
Copy link
Collaborator

Description

This code changes a lot of things within the code. I will list them here to help guide you through this PR:

  • In all directories with barrel files add all of the exports to these files.
  • Goes through and uses the barrel files to consolidates imports
  • Creates onClick handleSignIn function that navigates user to /list after sign in
  • Builds out a custom CSS checkbox with a purple check mark that bounces in upon clicking
  • Adds class names and styling to corresponding style sheets to apply global colors
  • Moves delete list button outside of navigation link to /manage-list, leaving user on list page post delete
  • Conditionally renders the categories in SortedItemsMap. If user doesn't have an item the category will not crowd UI
  • Creates default input styling in index.css to globally style text inputs with these class names
  • Adds temporary profile image on landing page post login. (this will be removed in merge conflict resolution)
  • Removes unused css from Link.css leftover from refactoring
    -Adds purple check mark favicon (this can be reverted or changed)

Related Issue

subissue #14
closes #89
closes #84

Acceptance Criteria

  • Ensure the list page and Manage list page adhere to app colors and global styling.
  • Refine search and create inputs by eliminating default styling and paint with app colors.
  • Update redirects post sign-in and delete list to navigate users to the lists page instead of the landing page or keep users on the lists page after deleting a list
  • standardize import structure across files for React, app functions/props, and CSS, ensuring index.js declarations are used for exports.

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

Landing Page

Screenshot 2024-04-06 at 12 21 36 AM

Lists Page

Screenshot 2024-04-06 at 12 23 23 AM

Manage-List Page

Screenshot 2024-04-06 at 12 23 45 AM

Favicon

Screenshot 2024-04-06 at 12 26 32 AM

After

Landing Page

Screenshot 2024-04-06 at 12 24 58 AM

Lists Page

Screenshot 2024-04-06 at 12 25 16 AM

Manage-List Page

Screenshot 2024-04-06 at 12 25 34 AM

Screenshot 2024-04-06 at 12 25 53 AM

Favicon

Screenshot 2024-04-06 at 12 24 14 AM

Testing Steps / QA Criteria

Login to app and start navigating around to see changes. Look over the AC and Summary to see all of the little details in the app.

krsnamara added 23 commits April 1, 2024 22:58
@krsnamara krsnamara added bug fix refactoring suggestion a suggestion for a new issue design sprint design sprint from issue 14 styling labels Apr 6, 2024
@krsnamara krsnamara requested review from mxmason and louieknolle April 6, 2024 04:27
@krsnamara krsnamara requested review from amalyam and piecanoe April 6, 2024 04:27
@krsnamara krsnamara self-assigned this Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

Visit the preview URL for this PR (updated for commit 73e85ce):

https://tcl-69-smart-shopping-list--pr90-mf-styling-list-and-jz5woo31.web.app

(expires Sat, 13 Apr 2024 22:54:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

Copy link
Collaborator

@louieknolle louieknolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and I'll approve before the peer reviews in case y'all need this merged in.

@piecanoe
Copy link
Collaborator

piecanoe commented Apr 6, 2024

This looks so good, Marty! Thanks for putting in so much work!

@krsnamara krsnamara merged commit 824a3fb into main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix design sprint design sprint from issue 14 refactoring styling suggestion a suggestion for a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-task issue includes small refactors, styling, and cleaning up some code organization
3 participants