-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MF] styling list and items pages #90
Conversation
…call for testing of checkbox
… success sign in navigate to /list
… locations for delete functionality
…item as purchased
Visit the preview URL for this PR (updated for commit 73e85ce): https://tcl-69-smart-shopping-list--pr90-mf-styling-list-and-jz5woo31.web.app (expires Sat, 13 Apr 2024 22:54:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and I'll approve before the peer reviews in case y'all need this merged in.
This looks so good, Marty! Thanks for putting in so much work! |
Description
This code changes a lot of things within the code. I will list them here to help guide you through this PR:
SortedItemsMap
. If user doesn't have an item the category will not crowd UI-Adds purple check mark favicon (this can be reverted or changed)
Related Issue
subissue #14
closes #89
closes #84
Acceptance Criteria
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fix
orenhancement
are common ones.Updates
Before
Landing Page
Lists Page
Manage-List Page
Favicon
After
Landing Page
Lists Page
Manage-List Page
Favicon
Testing Steps / QA Criteria
Login to app and start navigating around to see changes. Look over the AC and Summary to see all of the little details in the app.