Skip to content

Convert GHC warnings to errors #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Convert GHC warnings to errors #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42e53a6
chore: convert GHC warnings to errors
the-dr-lazy Feb 23, 2021
fb40302
refactor: fix GHC warnings
the-dr-lazy Feb 23, 2021
555ee93
Merge branch 'next' into feature/ci-ghc-warnings
the-dr-lazy Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cascade-api/cascade-api.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ common common-options
-- https://downloads.haskell.org/~ghc/master/users-guide/using-warnings.html
-- This list taken from https://medium.com/mercury-bank/enable-all-the-warnings-a0517bc081c3#
-- Enable all warnings with -Weverything, then disable the ones we don’t care about
ghc-options: -Weverything
ghc-options: -Werror -Weverything
-- missing-exported-signatures turns off the more strict -Wmissing-signatures.
-- See https://ghc.haskell.org/trac/ghc/ticket/14794#ticket
-Wno-missing-exported-signatures
Expand Down
3 changes: 0 additions & 3 deletions cascade-api/src/Cascade/Api/Database/Project.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ module Cascade.Api.Database.Project (ProjectTable(..), PrimaryKey(..), Row) wher

import qualified Cascade.Api.Data.Project as Project
import qualified Cascade.Api.Data.WrappedC as Wrapped
import Control.Lens ( _Wrapped'
, view
)
import Data.Generics.Labels ( )
import Database.Beam ( Beamable
, C
Expand Down
1 change: 0 additions & 1 deletion cascade-api/src/Cascade/Api/Effect/Database.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ import qualified Database.PostgreSQL.Simple as Postgres
import GHC.Generics
import Polysemy ( Embed
, Member
, Members
, Sem
, embed
, interpret
Expand Down
2 changes: 0 additions & 2 deletions cascade-api/src/Cascade/Api/Effect/Database/User.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ import Database.Beam ( SqlEq((==.))
, default_
, exists_
, filter_
, guard_
, insertExpressions
, select
, subselect_
, val_
, (||.)
)
Expand Down
1 change: 0 additions & 1 deletion cascade-api/src/Cascade/Api/Network/Server/Api/Authentication.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import Cascade.Api.Servant.Authentication ( headerAndPayloadCookieNam
import Control.Lens ( (^.)
, _Wrapped'
)
import qualified Data.ByteString as W8
import Polysemy ( Members
, Sem
)
Expand Down
2 changes: 1 addition & 1 deletion cascade-cli/cascade-cli.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ common common-options
-- https://downloads.haskell.org/~ghc/master/users-guide/using-warnings.html
-- This list taken from https://medium.com/mercury-bank/enable-all-the-warnings-a0517bc081c3#
-- Enable all warnings with -Weverything, then disable the ones we don’t care about
ghc-options: -Weverything
ghc-options: -Werror -Weverything
-- missing-exported-signatures turns off the more strict -Wmissing-signatures.
-- See https://ghc.haskell.org/trac/ghc/ticket/14794#ticket
-Wno-missing-exported-signatures
Expand Down
2 changes: 1 addition & 1 deletion cascade-prelude/cascade-prelude.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ common common-options
-- https://downloads.haskell.org/~ghc/master/users-guide/using-warnings.html
-- This list taken from https://medium.com/mercury-bank/enable-all-the-warnings-a0517bc081c3#
-- Enable all warnings with -Weverything, then disable the ones we don’t care about
ghc-options: -Weverything
ghc-options: -Werror -Weverything
-- missing-exported-signatures turns off the more strict -Wmissing-signatures.
-- See https://ghc.haskell.org/trac/ghc/ticket/14794#ticket
-Wno-missing-exported-signatures
Expand Down