Improvements to Flag Actions #3613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts-calendar/event-tickets into feature/flag-action-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
No tickets for now.
🗒️ Description
After the release of
5.19.2discussions around Stock handling and Attendee generation led us into identifying that we need more precision around Flag Action Markers as well as a way to guarantee that certain flag actions wont apply themselves again depending on its conditionals.🎥 Artifacts
List of Items to Handle
Decrease_StockandIncrease_Salesthere are the same, but one is currently handling just individual capacity and the other shared capacity. Improve Stock and Sales handling for Tickets Commerce Flag Actions #3614Increase_StockandDecrease_Salesthere are the same, but one is currently handling just individual capacity and the other shared capacity. Improve Stock and Sales handling for Tickets Commerce Flag Actions #3614total_salesfor tickets gets adjusted properly when refunds happen.handle()of each Flag Action so that we use it later to determine if we need to potentially execute that same given flag again.